From 660698802a65264459ac476062882b18593d5533 Mon Sep 17 00:00:00 2001 From: alwaysfrin <39822157+alwaysfrin@users.noreply.github.com> Date: Thu, 3 Jan 2019 14:02:16 +0800 Subject: [PATCH 1/4] =?UTF-8?q?shiro=E5=92=8Credis=E8=B0=83=E6=95=B4?= =?UTF-8?q?=EF=BC=8C=E8=A7=A3=E5=86=B3redis=E7=AE=A1=E9=81=93=E6=8B=A5?= =?UTF-8?q?=E5=A0=B5=E9=97=AE=E9=A2=98?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../core/api/iservice/base/IDataSimpleService.java | 8 +------ .../apiservice/controller/DemoAuthController.java | 6 +++--- .../controller/DemoRedisMqController.java | 17 ++++++++------- .../apiservice/controller/base/AuthController.java | 20 ++--------------- .../controller/base/SimpleController.java | 16 +++++++------- .../controller/base/WhiteController.java | 25 +++++++++++++++++++++- .../core/apiservice/dao/IMachineFactoryDao.java | 13 ++--------- .../serviceimpl/base/DataSimpleServiceImpl.java | 8 ++----- 8 files changed, 51 insertions(+), 62 deletions(-) diff --git a/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/base/IDataSimpleService.java b/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/base/IDataSimpleService.java index 3602c5c..91b32b0 100644 --- a/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/base/IDataSimpleService.java +++ b/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/base/IDataSimpleService.java @@ -1,11 +1,5 @@ package cn.estsh.i3plus.core.api.iservice.base; -import cn.estsh.i3plus.pojo.mes.MachineFactory; -import org.springframework.transaction.annotation.Transactional; - -import java.util.List; - - /** * @Description : service服务,根据方法名自动添加事务 * @Reference : @@ -15,7 +9,7 @@ import java.util.List; **/ public interface IDataSimpleService { - void saveMachineFactory(MachineFactory machineFactory); + //void saveMachineFactory(MachineFactory machineFactory); /*@Transactional void updateMachineFactoryNameById(long id, String factoryName); diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoAuthController.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoAuthController.java index 30c3295..4029f08 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoAuthController.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoAuthController.java @@ -50,7 +50,7 @@ public class DemoAuthController extends CoreBaseController { AuthUtil.setSessionObject("languageCode",languageCode); return new ResultBean(true,""); } catch (ImppBusiException e) { - return new ResultBean(false,e.getErrorDetail() + ",so:" + e.getErrorSolution()); + return new ResultBean(false,e.getErrorDetail() + "-[解决]" + e.getErrorSolution()); } } @@ -66,7 +66,7 @@ public class DemoAuthController extends CoreBaseController { AuthUtil.logout(); return new ResultBean(true,""); } catch (ImppBusiException e) { - return new ResultBean(false,e.getErrorDetail() + ",so:" + e.getErrorSolution()); + return new ResultBean(false,e.getErrorDetail() + "-[解决]" + e.getErrorSolution()); } } @@ -91,7 +91,7 @@ public class DemoAuthController extends CoreBaseController { return new ResultBean(true,"",sUser); } catch (ImppBusiException e) { - return new ResultBean(false,e.getErrorDetail() + ",so:" + e.getErrorSolution()); + return new ResultBean(false,e.getErrorDetail() + "-[解决]" + e.getErrorSolution()); } } diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoRedisMqController.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoRedisMqController.java index 2001c43..66f3cab 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoRedisMqController.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoRedisMqController.java @@ -7,11 +7,10 @@ import cn.estsh.i3plus.pojo.base.enumutil.CommonEnumUtil; import cn.estsh.i3plus.pojo.platform.bean.SessionUser; import cn.estsh.impp.framework.base.controller.CoreBaseController; import cn.estsh.impp.framework.boot.auth.AuthUtil; -import cn.estsh.impp.framework.boot.util.ResultBean; -import cn.estsh.i3plus.pojo.mes.MachineFactory; import cn.estsh.impp.framework.boot.exception.ImppExceptionBuilder; import cn.estsh.impp.framework.boot.exception.ImppExceptionEnum; import cn.estsh.impp.framework.boot.util.ImppRedis; +import cn.estsh.impp.framework.boot.util.ResultBean; import com.rabbitmq.client.Channel; import io.swagger.annotations.Api; import io.swagger.annotations.ApiOperation; @@ -22,7 +21,9 @@ import org.springframework.amqp.rabbit.connection.CachingConnectionFactory; import org.springframework.amqp.rabbit.core.RabbitTemplate; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.context.i18n.LocaleContextHolder; -import org.springframework.web.bind.annotation.*; +import org.springframework.web.bind.annotation.GetMapping; +import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RestController; import javax.annotation.Resource; import java.io.IOException; @@ -66,7 +67,7 @@ public class DemoRedisMqController extends CoreBaseController{ @ApiOperation(value="缓存",notes="放入数据") public ResultBean putCache(){ //放入缓存 - redisCore.putObject("machineFactory",new MachineFactory("111","nnnn")); + //redisCore.putObject("machineFactory",new MachineFactory("111","nnnn")); redisCore.putObject("wms","123123123"); return new ResultBean(true,"已放入缓存"); @@ -75,11 +76,11 @@ public class DemoRedisMqController extends CoreBaseController{ @GetMapping(value="/get-cache") @ApiOperation(value="缓存",notes="获取数据") public ResultBean getCache(){ - MachineFactory mf = (MachineFactory) redisCore.getObject("machineFactory"); - System.out.println("1===== " + mf); + //MachineFactory mf = (MachineFactory) redisCore.getObject("machineFactory"); + //System.out.println("1===== " + mf); System.out.println("2===== " + redisCore.getObject("wms")); - return new ResultBean(true,mf); + return new ResultBean(true); } @GetMapping(value="/send-mq") @@ -94,7 +95,7 @@ public class DemoRedisMqController extends CoreBaseController{ this.rabbitTemplate.convertAndSend(I3CoreQueueConfig.DEMO_HANDLE_QUEUE, context); System.out.println("发送Object数据 : " + context); - this.rabbitTemplate.convertAndSend(I3CoreQueueConfig.DEMO_OBJ_QUEUE, new MachineFactory("111mq","rabbit")); + //this.rabbitTemplate.convertAndSend(I3CoreQueueConfig.DEMO_OBJ_QUEUE, new MachineFactory("111mq","rabbit")); return new ResultBean(true,"操作成功"); } diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/AuthController.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/AuthController.java index 94bc36f..a0be167 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/AuthController.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/AuthController.java @@ -48,22 +48,6 @@ public class AuthController extends CoreBaseController { * * @return */ - @GetMapping(value="/logout") - @ApiOperation(value="登出",notes="登出") - public ResultBean logout(){ - LOGGER.info("用户退出..."); - try { - AuthUtil.logout(); - return new ResultBean(true,"").build(); - } catch (ImppBusiException e) { - return new ResultBean(false,e.getErrorDetail() + ",so:" + e.getErrorSolution()); - } - } - - /** - * - * @return - */ @GetMapping(value="/get-user-info") @ApiOperation(value="获取登录用户信息",notes="获取当前登录用户详细信息") public ResultBean getUserInfo(){ @@ -73,7 +57,7 @@ public class AuthController extends CoreBaseController { LOGGER.info("用户:{}",sUser); return new ResultBean(true,"",sUser.getUserInfo()); } catch (ImppBusiException e) { - return new ResultBean(false,e.getErrorDetail() + ",so:" + e.getErrorSolution()); + return new ResultBean(false,e.getErrorDetail() + "-[解决]" + e.getErrorSolution()); } } @@ -90,7 +74,7 @@ public class AuthController extends CoreBaseController { LOGGER.info("用户:{}",sUser); return new ResultBean(true,"",sUser.getUser()); } catch (ImppBusiException e) { - return new ResultBean(false,e.getErrorDetail() + ",so:" + e.getErrorSolution()); + return new ResultBean(false,e.getErrorDetail() + "-[解决]" + e.getErrorSolution()); } } diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/SimpleController.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/SimpleController.java index 4c62aaa..dbcf777 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/SimpleController.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/SimpleController.java @@ -4,15 +4,15 @@ import cn.estsh.i3plus.core.api.iservice.base.IDataSimpleService; import cn.estsh.i3plus.platform.common.util.PlatformConstWords; import cn.estsh.impp.framework.base.controller.CoreBaseController; import cn.estsh.impp.framework.boot.util.ResultBean; -import cn.estsh.i3plus.pojo.mes.MachineFactory; import io.swagger.annotations.Api; import io.swagger.annotations.ApiOperation; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; -import org.springframework.web.bind.annotation.*; - -import java.util.List; +import org.springframework.web.bind.annotation.PutMapping; +import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RequestParam; +import org.springframework.web.bind.annotation.RestController; /** * @Description : @@ -33,10 +33,10 @@ public class SimpleController extends CoreBaseController{ @PutMapping(value="/insert") @ApiOperation(value="service服务",notes="返回内容添加service") public ResultBean insertFactory(@RequestParam("name")String name, @RequestParam("code")String code){ - MachineFactory machineFactory = new MachineFactory(); - machineFactory.setFactoryName(name); - machineFactory.setFactoryCode(code); - dataSimpleService.saveMachineFactory(machineFactory); +// MachineFactory machineFactory = new MachineFactory(); +// machineFactory.setFactoryName(name); +// machineFactory.setFactoryCode(code); +// dataSimpleService.saveMachineFactory(machineFactory); return new ResultBean(true,"工厂已保存"); } diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/WhiteController.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/WhiteController.java index f4e87c8..525c5a2 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/WhiteController.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/WhiteController.java @@ -71,7 +71,23 @@ public class WhiteController extends CoreBaseController { } } - @GetMapping(value="/auth/login") + /** + * + * @return + */ + @GetMapping(value="/logout") + @ApiOperation(value="登出",notes="登出") + public ResultBean logout(){ + LOGGER.info("用户退出..."); + try { + AuthUtil.logout(); + return new ResultBean(true,"您已安全退出。").build(); + } catch (ImppBusiException e) { + return new ResultBean(false,e.getErrorDetail() + "-[解决]" + e.getErrorSolution()); + } + } + + @GetMapping(value="/login") @ApiOperation(value="登陆",notes="登陆") public ResultBean login(HttpServletRequest request, String loginName, String loginPwd, String languageCode){ LOGGER.info("用户登陆 loginName:{} loginPwd:{} languageCode:{}",loginName,loginPwd,languageCode); @@ -81,6 +97,13 @@ public class WhiteController extends CoreBaseController { ValidatorBean.checkNotNull(loginPwd,"密码不能为空"); ValidatorBean.checkNotNull(languageCode,"语言不能为空"); + try { + //先进行登出 + AuthUtil.logout(); + }catch (Exception e){ + e.printStackTrace(); + } + SessionUser user = userService.queryUserLogin(loginName,loginPwd,languageCode); String redisKey = CommonConstWords.USER_LOGIN_ERROR + "_" + user.getUser().getId(); diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/dao/IMachineFactoryDao.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/dao/IMachineFactoryDao.java index f3409ee..9fe06fc 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/dao/IMachineFactoryDao.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/dao/IMachineFactoryDao.java @@ -1,14 +1,5 @@ package cn.estsh.i3plus.core.apiservice.dao; -import cn.estsh.i3plus.pojo.mes.MachineFactory; -import org.springframework.data.jpa.repository.Modifying; -import org.springframework.data.jpa.repository.Query; -import org.springframework.data.repository.CrudRepository; -import org.springframework.data.repository.query.Param; -import org.springframework.stereotype.Repository; - -import java.util.List; - /** * @Description : hql申明查询demo * 继承了crudrepository,包含了常用hql方法 @@ -18,7 +9,7 @@ import java.util.List; * @Modify: **/ //@Repository -public interface IMachineFactoryDao extends CrudRepository { +//public interface IMachineFactoryDao extends CrudRepository { //此处findBy开头,会自动根据属性名进行查询 /*List findByFactoryName(String factoryName); @@ -42,4 +33,4 @@ public interface IMachineFactoryDao extends CrudRepository //自定义Hql @Query("from MachineFactory mf where mf.createDatetime like '2018-01-01%'") List findMachineFactorySpecial();*/ -} +//} diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/base/DataSimpleServiceImpl.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/base/DataSimpleServiceImpl.java index 33a2d5b..4eda967 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/base/DataSimpleServiceImpl.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/base/DataSimpleServiceImpl.java @@ -1,12 +1,8 @@ package cn.estsh.i3plus.core.apiservice.serviceimpl.base; import cn.estsh.i3plus.core.api.iservice.base.IDataSimpleService; -import cn.estsh.i3plus.core.apiservice.dao.IMachineFactoryDao; -import cn.estsh.i3plus.pojo.base.codemaker.SnowflakeIdMaker; -import cn.estsh.i3plus.pojo.mes.MachineFactory; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; /** @@ -20,7 +16,7 @@ import org.springframework.stereotype.Service; public class DataSimpleServiceImpl implements IDataSimpleService { private Logger LOGGER = LoggerFactory.getLogger(this.getClass()); - @Autowired + /*@Autowired private IMachineFactoryDao machineFactoryDao; @Override @@ -28,7 +24,7 @@ public class DataSimpleServiceImpl implements IDataSimpleService { //生成主键 machineFactory.setId(new SnowflakeIdMaker().nextId()); machineFactoryDao.save(machineFactory); - } + }*/ /* @Override public void updateMachineFactoryNameById(long id, String factoryName) { From e93b7992cf85f8a7bb284c698e2afb15172840f1 Mon Sep 17 00:00:00 2001 From: alwaysfrin <39822157+alwaysfrin@users.noreply.github.com> Date: Thu, 3 Jan 2019 14:07:27 +0800 Subject: [PATCH 2/4] =?UTF-8?q?=E7=99=BD=E5=90=8D=E8=B7=AF=E5=BE=84?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../estsh/i3plus/core/apiservice/controller/base/WhiteController.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/WhiteController.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/WhiteController.java index 525c5a2..4d1012f 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/WhiteController.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/base/WhiteController.java @@ -75,7 +75,7 @@ public class WhiteController extends CoreBaseController { * * @return */ - @GetMapping(value="/logout") + @GetMapping(value="/auth/logout") @ApiOperation(value="登出",notes="登出") public ResultBean logout(){ LOGGER.info("用户退出..."); @@ -87,7 +87,7 @@ public class WhiteController extends CoreBaseController { } } - @GetMapping(value="/login") + @GetMapping(value="/auth/login") @ApiOperation(value="登陆",notes="登陆") public ResultBean login(HttpServletRequest request, String loginName, String loginPwd, String languageCode){ LOGGER.info("用户登陆 loginName:{} loginPwd:{} languageCode:{}",loginName,loginPwd,languageCode); From 168df4346599d0fede7612819cb84bea8b4cb164 Mon Sep 17 00:00:00 2001 From: "wei.peng" Date: Thu, 3 Jan 2019 14:32:53 +0800 Subject: [PATCH 3/4] =?UTF-8?q?=E7=BB=84=E7=BB=87=E7=AE=A1=E7=90=86?= =?UTF-8?q?=E7=88=B6=E8=8A=82=E7=82=B9Bug=20=E4=BF=AE=E5=A4=8D=20=E5=A4=8D?= =?UTF-8?q?=E6=9D=82=E6=9F=A5=E8=AF=A2=E6=B7=BB=E5=8A=A0=E9=BB=98=E8=AE=A4?= =?UTF-8?q?=E6=8E=92=E5=BA=8F?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../core/apiservice/serviceimpl/busi/CoreTreeService.java | 15 +++++++++++++-- .../apiservice/serviceimpl/busi/SysPositionService.java | 2 +- .../core/apiservice/serviceimpl/busi/SysUserService.java | 7 +++---- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/CoreTreeService.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/CoreTreeService.java index 6e6bc54..1c6665f 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/CoreTreeService.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/CoreTreeService.java @@ -237,8 +237,19 @@ public class CoreTreeService implements ICoreTreeService { @Override @ApiOperation(value = "父节点检查",notes = "检查组织的父节点是否是当前节点的子节点") public void doValidatorSysOrganizeParentId(SysOrganize organize) { - findSysOrganizeChildrenTreePack(organize,0); - validatorSysOrganizeParentId(organize.getChildList(),organize.getParentId()); + if(organize != null){ + if(organize.getParentId().longValue() == organize.getId().longValue()){ + throw ImppExceptionBuilder.newInstance() + .setSystemID(CommonEnumUtil.SOFT_TYPE.CORE.getCode()) + .setErrorCode(ImppExceptionEnum.VARIFY_EXCEPTION.getCode()) + .setErrorDetail("上级组织不能为当前组织") + .setErrorSolution("请重新操作") + .build(); + } + + findSysOrganizeChildrenTreePack(organize,0); + validatorSysOrganizeParentId(organize.getChildList(),organize.getParentId()); + } } @Override diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysPositionService.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysPositionService.java index b0275d7..410a985 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysPositionService.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysPositionService.java @@ -109,7 +109,7 @@ public class SysPositionService implements ISysPositionService { LOGGER.info("岗位信息 POSITION position:{}", position); positionRDao.update(position); // 修改冗余信息 - personnelService.refreshRefSysUserInfoPositionRdd(position.getId()); +// personnelService.refreshRefSysUserInfoPositionRdd(position.getId()); } @Override diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysUserService.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysUserService.java index 4b5acb1..fe3046e 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysUserService.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysUserService.java @@ -177,15 +177,14 @@ public class SysUserService implements ISysUserService { @ApiOperation(value = "刷新账号", notes = "刷新账号登录信息") public void refreshUserLoginInformation(Long userId) { SysUser user = sysUserRDao.getById(userId); - SysUserInfo userInfo = sysUserInfoRDao.getById(user.getUserInfoId()); - user.setUserLoginLastDateTime(TimeTool.getNowTime(true)); user.setUserLoginNum(user.getUserLoginNum() + 1); + sysUserRDao.save(user); + + SysUserInfo userInfo = sysUserInfoRDao.getById(user.getUserInfoId()); userInfo.setUserLoginLastDateTime(TimeTool.getNowTime(true)); userInfo.setUserLoginNum(userInfo.getUserLoginNum() + 1); - sysUserInfoRDao.save(userInfo); - sysUserRDao.save(user); } @Override From 24989daf09c17a0f42a5f3780ac3d0dfd853a1d1 Mon Sep 17 00:00:00 2001 From: "wei.peng" Date: Thu, 3 Jan 2019 14:35:06 +0800 Subject: [PATCH 4/4] =?UTF-8?q?=E7=BB=84=E7=BB=87=E7=AE=A1=E7=90=86?= =?UTF-8?q?=E7=88=B6=E8=8A=82=E7=82=B9Bug=20=E4=BF=AE=E5=A4=8D=20=E9=83=A8?= =?UTF-8?q?=E9=97=A8=E7=AE=A1=E7=90=86=E7=88=B6=E8=8A=82=E7=82=B9Bug=20?= =?UTF-8?q?=E4=BF=AE=E5=A4=8D=20=E5=A4=8D=E6=9D=82=E6=9F=A5=E8=AF=A2?= =?UTF-8?q?=E6=B7=BB=E5=8A=A0=E9=BB=98=E8=AE=A4=E6=8E=92=E5=BA=8F?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../core/apiservice/serviceimpl/busi/CoreTreeService.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/CoreTreeService.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/CoreTreeService.java index 1c6665f..4b56eea 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/CoreTreeService.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/CoreTreeService.java @@ -165,8 +165,18 @@ public class CoreTreeService implements ICoreTreeService { @Override @ApiOperation(value = "父节点检查",notes = "检查部门的父节点是否是当前节点的子节点") public void doValidatorSysDepartmentParentId(SysDepartment department) { - findSysDepartmentChildrenTreePack(department,0); - validatorSysDepartmentParentId(department.getChildList(),department.getParentId()); + if(department != null){ + if(department.getParentId().longValue() == department.getId().longValue()){ + throw ImppExceptionBuilder.newInstance() + .setSystemID(CommonEnumUtil.SOFT_TYPE.CORE.getCode()) + .setErrorCode(ImppExceptionEnum.VARIFY_EXCEPTION.getCode()) + .setErrorDetail("上级部门不能为当前部门") + .setErrorSolution("请重新操作") + .build(); + } + findSysDepartmentChildrenTreePack(department,0); + validatorSysDepartmentParentId(department.getChildList(),department.getParentId()); + } } @Override