From 3840dea6491826ac42de3d0671a2334ea9430ee0 Mon Sep 17 00:00:00 2001 From: "yunhao.wang" Date: Wed, 28 Nov 2018 20:21:53 +0800 Subject: [PATCH 1/2] =?UTF-8?q?=E5=8A=9F=E8=83=BD=E7=BB=86=E8=8A=82?= =?UTF-8?q?=E8=B0=83=E6=95=B4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../busi/ISysTaskTimeExpressionService.java | 13 ++-- .../api/iservice/busi/ISysTaskTimeService.java | 18 ++++- .../controller/busi/SysTaskTimeController.java | 83 ++++++++-------------- .../busi/SysTaskTimeExpressionController.java | 63 ++++++---------- .../core/apiservice/mq/LetterQueueReceiver.java | 5 +- .../busi/SysTaskTimeExpressionService.java | 10 ++- .../serviceimpl/busi/SysTaskTimeService.java | 21 ++++-- 7 files changed, 104 insertions(+), 109 deletions(-) diff --git a/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysTaskTimeExpressionService.java b/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysTaskTimeExpressionService.java index 430e22e..7955212 100644 --- a/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysTaskTimeExpressionService.java +++ b/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysTaskTimeExpressionService.java @@ -2,10 +2,8 @@ package cn.estsh.i3plus.core.api.iservice.busi; import cn.estsh.i3plus.pojo.base.bean.ListPager; import cn.estsh.i3plus.pojo.base.common.Pager; -import cn.estsh.i3plus.pojo.platform.bean.SessionUser; -import cn.estsh.i3plus.pojo.platform.bean.SysFile; -import cn.estsh.i3plus.pojo.platform.bean.SysRole; import cn.estsh.i3plus.pojo.platform.bean.SysTaskTimeExpression; +import io.swagger.annotations.ApiOperation; import java.util.List; @@ -22,12 +20,14 @@ public interface ISysTaskTimeExpressionService { * 修改数据 * @param taskTimeExpression */ + @ApiOperation(value = "修改数据") void updateSysTaskTimeExpression(SysTaskTimeExpression taskTimeExpression); /** - * 根据Key 删除数据 + * 根据id删除数据 * @param id */ + @ApiOperation(value = "根据id删除数据") void deleteSysTaskTimeExpressionById(Long id); /** @@ -35,12 +35,14 @@ public interface ISysTaskTimeExpressionService { * @param taskTimeExpression * @return */ + @ApiOperation(value = "新增数据") SysTaskTimeExpression insertSysTaskTimeExpression(SysTaskTimeExpression taskTimeExpression); /** * 查询所有数据 * @return */ + @ApiOperation(value = "查询所有数据") List listSysTaskTimeExpression(); /** @@ -48,6 +50,7 @@ public interface ISysTaskTimeExpressionService { * @param id * @return */ + @ApiOperation(value = "根据ID 查询任务表达式") SysTaskTimeExpression getSysTaskTimeExpressionById(Long id); /** @@ -56,11 +59,13 @@ public interface ISysTaskTimeExpressionService { * @param pager * @return */ + @ApiOperation(value = "任务表达式查询，分页，排序") ListPager querySysTaskTimeExpressionByPager(SysTaskTimeExpression taskTimeExpression, Pager pager); /** * 任务表达式批量删除 * @param ids */ + @ApiOperation(value = "任务表达式批量删除") void deleteSysTaskTimeExpressionByIds(Long[] ids); } diff --git a/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysTaskTimeService.java b/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysTaskTimeService.java index 703116e..4f856c5 100644 --- a/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysTaskTimeService.java +++ b/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysTaskTimeService.java @@ -5,6 +5,7 @@ import cn.estsh.i3plus.pojo.base.common.Pager; import cn.estsh.i3plus.pojo.platform.bean.SessionUser; import cn.estsh.i3plus.pojo.platform.bean.SysTaskTime; import cn.estsh.i3plus.pojo.platform.bean.SysTaskTimeExpression; +import io.swagger.annotations.ApiOperation; import java.util.List; @@ -18,16 +19,18 @@ import java.util.List; public interface ISysTaskTimeService { /** - * 新增数据 + * 新增定时任务 * @param taskTime * @return */ + @ApiOperation(value = "新增定时任务") SysTaskTime insertSysTaskTime(SysTaskTime taskTime, SysTaskTimeExpression taskTimeExpression); /** - * 修改数据 + * 修改定时任务 * @param taskTime */ + @ApiOperation(value = "修改定时任务") void updateSysTaskTime(SysTaskTime taskTime, SysTaskTimeExpression taskTimeExpression); /** @@ -36,18 +39,21 @@ public interface ISysTaskTimeService { * @param status 任务状态 * @param user 当前会话用户 */ + @ApiOperation(value = "修改任务状态") void updateSysTaskTimeStatus(Long id, int status, SessionUser user); /** - * 根据Key 删除数据 + * 根据根据id删除数据 * @param id */ + @ApiOperation(value = "根据根据id删除数据") void deleteSysTaskTimeById(Long id); /** * 查询所有数据 * @return */ + @ApiOperation(value = "查询所有数据") List listSysTaskTime(); /** @@ -55,6 +61,7 @@ public interface ISysTaskTimeService { * @param id * @return */ + @ApiOperation(value = "根据id 数据") SysTaskTime getSysTaskTimeById(Long id); /** @@ -63,12 +70,14 @@ public interface ISysTaskTimeService { * @param pager * @return */ + @ApiOperation(value = "定时任务复制查询，分页，排序") ListPager querySysTaskTimeByPager(SysTaskTime taskTime, Pager pager); /** * 根据id批量删除定时任务 * @param ids */ + @ApiOperation(value = "根据id批量删除定时任务") void deleteSysTaskTimeByIds(Long[] ids); /** @@ -76,6 +85,7 @@ public interface ISysTaskTimeService { * @param ids * */ + @ApiOperation(value = "批量修改定时任务状态") void updateSysTaskTimeStatusByIds(Long[] ids, Integer status); /** @@ -84,11 +94,13 @@ public interface ISysTaskTimeService { * @param name * @param groupName */ + @ApiOperation(value = "修改最后时间") void doSysTaskTimeLastDateByNameAndGroupName(String lastDate,String name,String groupName); /** * 立即执行 * @param id */ + @ApiOperation(value = "立即执行") void executeSysTaskTimeById(Long id); } diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysTaskTimeController.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysTaskTimeController.java index 7adb54f..df606a9 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysTaskTimeController.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysTaskTimeController.java @@ -2,14 +2,13 @@ package cn.estsh.i3plus.core.apiservice.controller.busi; import cn.estsh.i3plus.core.api.iservice.busi.ISysTaskTimeExpressionService; import cn.estsh.i3plus.core.api.iservice.busi.ISysTaskTimeService; -import cn.estsh.i3plus.platform.common.convert.ConvertBean; import cn.estsh.i3plus.platform.common.tool.StringTool; import cn.estsh.i3plus.pojo.base.bean.ListPager; import cn.estsh.i3plus.pojo.base.common.Pager; import cn.estsh.i3plus.pojo.base.enumutil.CommonEnumUtil; -import cn.estsh.i3plus.pojo.base.enumutil.ImppEnumUtil; import cn.estsh.i3plus.pojo.base.enumutil.ResourceEnumUtil; -import cn.estsh.i3plus.pojo.platform.bean.*; +import cn.estsh.i3plus.pojo.platform.bean.SysTaskTime; +import cn.estsh.i3plus.pojo.platform.bean.SysTaskTimeExpression; import cn.estsh.impp.framework.base.controller.CoreBaseController; import cn.estsh.impp.framework.boot.auth.AuthUtil; import cn.estsh.impp.framework.boot.exception.ImppBusiException; @@ -75,12 +74,10 @@ public class SysTaskTimeController extends CoreBaseController{ taskTimeService.executeSysTaskTimeById(taskTime.getId()); } return ResultBean.success("操作成功").setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()).setResultObject(taskTime); - } catch (ImppBusiException busExcep) { - LOGGER.error(busExcep.getErrorMsg() + "：{}", busExcep.getErrorDetail(), busExcep); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); - } catch (Exception e) { - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}", e.getMessage(), e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + }catch(Exception e){ + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -113,12 +110,10 @@ public class SysTaskTimeController extends CoreBaseController{ taskTimeService.executeSysTaskTimeById(taskTime.getId()); } return ResultBean.success("操作成功").setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()).setResultObject(taskTime); - } catch (ImppBusiException busExcep) { - LOGGER.error(busExcep.getErrorMsg() + "：{}", busExcep.getErrorDetail(), busExcep); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); - } catch (Exception e) { - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}", e.getMessage(), e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + }catch(Exception e){ + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -131,12 +126,10 @@ public class SysTaskTimeController extends CoreBaseController{ taskTimeService.deleteSysTaskTimeById(Long.parseLong(id)); return ResultBean.success().setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); - } catch (ImppBusiException busExcep) { - LOGGER.error(busExcep.getErrorMsg() + "：{}", busExcep.getErrorDetail(), busExcep); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); - } catch (Exception e) { - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}", e.getMessage(), e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + }catch(Exception e){ + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -148,12 +141,10 @@ public class SysTaskTimeController extends CoreBaseController{ return ResultBean.success("操作成功") .setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()) .setResultList(list); - } catch (ImppBusiException busExcep) { - LOGGER.error(busExcep.getErrorMsg() + "：{}", busExcep.getErrorDetail(), busExcep); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); - } catch (Exception e) { - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}", e.getMessage(), e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + }catch(Exception e){ + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -169,31 +160,27 @@ public class SysTaskTimeController extends CoreBaseController{ return ResultBean.success("操作成功") .setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()) .setResultObject(taskTime); - } catch (ImppBusiException busExcep) { - LOGGER.error(busExcep.getErrorMsg() + "：{}", busExcep.getErrorDetail(), busExcep); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); - } catch (Exception e) { - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}", e.getMessage(), e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + }catch(Exception e){ + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } - @PutMapping(value = "/status") + @PutMapping(value = "/status/{id}/{status}") @ApiOperation(value = "修改定时任务状态", notes = "根据ID修改定时任务状态") - public ResultBean updateQuartzStatus(String id,int status) { + public ResultBean updateQuartzStatus(@PathVariable("id") String idStr,@PathVariable("status") Integer status) { try { // 数据校验 - ValidatorBean.checkNotNull(id, "功能id 不能为空"); - ValidatorBean.checkNotZero(status, "功能状态不能为空"); + ValidatorBean.checkNotNull(idStr, "id 不能为空"); + ValidatorBean.checkNotZero(status, "状态不能为空"); - taskTimeService.updateSysTaskTimeStatus(Long.parseLong(id),status,AuthUtil.getSessionUser()); + taskTimeService.updateSysTaskTimeStatus(Long.parseLong(idStr),status,AuthUtil.getSessionUser()); return new ResultBean(true); - } catch(ImppBusiException busExcep){ - LOGGER.error(busExcep.getErrorMsg() + "：{}",busExcep.getErrorDetail(),busExcep); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); }catch(Exception e){ - LOGGER.error(ImppExceptionEnum.BUSINESS_EXCEPTION_DATA_ERROR.getDescription() + "：{}",e.getMessage(),e); - return ResultBean.fail().setCode(ImppExceptionEnum.BUSINESS_EXCEPTION_DATA_ERROR.getCode()); + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -204,11 +191,9 @@ public class SysTaskTimeController extends CoreBaseController{ ListPager taskTimeListPager = taskTimeService.querySysTaskTimeByPager(taskTime,pager); return ResultBean.success("查询成功").setListPager(taskTimeListPager).setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); }catch(ImppBusiException busExcep){ - LOGGER.error(busExcep.getErrorMsg() + "：{}",busExcep.getErrorDetail(),busExcep); return ResultBean.fail(busExcep); }catch(Exception e){ - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}",e.getMessage(),e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -227,11 +212,9 @@ public class SysTaskTimeController extends CoreBaseController{ taskTimeService.deleteSysTaskTimeByIds(StringTool.getArrayLong(ids)); return ResultBean.success("删除成功").setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); }catch(ImppBusiException busExcep){ - LOGGER.error(busExcep.getErrorMsg() + "：{}",busExcep.getErrorDetail(),busExcep); return ResultBean.fail(busExcep); }catch(Exception e){ - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}",e.getMessage(),e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -251,12 +234,10 @@ public class SysTaskTimeController extends CoreBaseController{ taskTimeService.updateSysTaskTimeStatusByIds(StringTool.getArrayLong(ids),status); return ResultBean.success("操作成功").setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); - } catch(ImppBusiException busExcep){ - LOGGER.error(busExcep.getErrorMsg() + "：{}",busExcep.getErrorDetail(),busExcep); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); }catch(Exception e){ - LOGGER.error(ImppExceptionEnum.BUSINESS_EXCEPTION_DATA_ERROR.getDescription() + "：{}",e.getMessage(),e); - return ResultBean.fail().setCode(ImppExceptionEnum.BUSINESS_EXCEPTION_DATA_ERROR.getCode()); + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -269,12 +250,10 @@ public class SysTaskTimeController extends CoreBaseController{ taskTimeService.executeSysTaskTimeById(Long.parseLong(id)); return ResultBean.success("操作成功").setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); - } catch (ImppBusiException busExcep) { - LOGGER.error(busExcep.getErrorMsg() + "：{}", busExcep.getErrorDetail(), busExcep); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); - } catch (Exception e) { - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}", e.getMessage(), e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + }catch(Exception e){ + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } } \ No newline at end of file diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysTaskTimeExpressionController.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysTaskTimeExpressionController.java index 5049f3a..808c256 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysTaskTimeExpressionController.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysTaskTimeExpressionController.java @@ -50,14 +50,11 @@ public class SysTaskTimeExpressionController extends CoreBaseController{ .notNull("expressionStartDatetime",timeExpression.getExpressionStartDatetime()); taskTimeExpressionService.insertSysTaskTimeExpression(timeExpression); - return ResultBean.success("操作成功").setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); - } catch (ImppBusiException busExcep) { - LOGGER.error(busExcep.getErrorMsg() + "：{}", busExcep.getErrorDetail(), busExcep); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); - } catch (Exception e) { - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}", e.getMessage(), e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + }catch(Exception e){ + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -74,12 +71,10 @@ public class SysTaskTimeExpressionController extends CoreBaseController{ taskTimeExpressionService.updateSysTaskTimeExpression(timeExpression); return ResultBean.success("操作成功").setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); - } catch (ImppBusiException busExcep) { - LOGGER.error(busExcep.getErrorMsg() + "：{}", busExcep.getErrorDetail(), busExcep); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); - } catch (Exception e) { - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}", e.getMessage(), e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + }catch(Exception e){ + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -92,12 +87,10 @@ public class SysTaskTimeExpressionController extends CoreBaseController{ taskTimeExpressionService.deleteSysTaskTimeExpressionById(Long.parseLong(id)); return ResultBean.success().setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); - } catch (ImppBusiException busExcep) { - LOGGER.error(busExcep.getErrorMsg() + "：{}", busExcep.getErrorDetail(), busExcep); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); - } catch (Exception e) { - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}", e.getMessage(), e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + }catch(Exception e){ + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -106,15 +99,11 @@ public class SysTaskTimeExpressionController extends CoreBaseController{ public ResultBean findSysTaskTimeExpressionAll() { try { List list = taskTimeExpressionService.listSysTaskTimeExpression(); - return ResultBean.success("操作成功") - .setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()) - .setResultList(list); - } catch (ImppBusiException busExcep) { - LOGGER.error(busExcep.getErrorMsg() + "：{}", busExcep.getErrorDetail(), busExcep); + return ResultBean.success("操作成功").setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()).setResultList(list); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); - } catch (Exception e) { - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}", e.getMessage(), e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + }catch(Exception e){ + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -127,15 +116,11 @@ public class SysTaskTimeExpressionController extends CoreBaseController{ SysTaskTimeExpression taskTimeExpression = taskTimeExpressionService.getSysTaskTimeExpressionById(Long.parseLong(id)); - return ResultBean.success("操作成功") - .setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()) - .setResultObject(taskTimeExpression); - } catch (ImppBusiException busExcep) { - LOGGER.error(busExcep.getErrorMsg() + "：{}", busExcep.getErrorDetail(), busExcep); + return ResultBean.success("操作成功").setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()).setResultObject(taskTimeExpression); + }catch(ImppBusiException busExcep){ return ResultBean.fail(busExcep); - } catch (Exception e) { - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}", e.getMessage(), e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + }catch(Exception e){ + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @@ -146,19 +131,17 @@ public class SysTaskTimeExpressionController extends CoreBaseController{ ListPager taskTimeExpressionListPager = taskTimeExpressionService.querySysTaskTimeExpressionByPager(taskTimeExpression,pager); return ResultBean.success("查询成功").setListPager(taskTimeExpressionListPager).setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); }catch(ImppBusiException busExcep){ - LOGGER.error(busExcep.getErrorMsg() + "：{}",busExcep.getErrorDetail(),busExcep); return ResultBean.fail(busExcep); }catch(Exception e){ - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}",e.getMessage(),e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } @DeleteMapping("/batch-delete") @ApiOperation(value = "根据id批量删除时间表达式",notes = "根据id批量删除时间表达式") - public ResultBean deleteSysTaskTimeExpressionByIds(String[] ids){ + public ResultBean deleteSysTaskTimeExpressionByIds(String[] idsStr){ try{ - if(ids.length == 0){ + if(idsStr.length == 0){ throw ImppExceptionBuilder.newInstance() .setSystemID(CommonEnumUtil.SOFT_TYPE.CORE.getCode()) .setErrorCode(ImppExceptionEnum.VARIFY_EXCEPTION.getCode()) @@ -166,14 +149,12 @@ public class SysTaskTimeExpressionController extends CoreBaseController{ .build(); } - taskTimeExpressionService.deleteSysTaskTimeExpressionByIds(StringTool.getArrayLong(ids)); + taskTimeExpressionService.deleteSysTaskTimeExpressionByIds(StringTool.getArrayLong(idsStr)); return ResultBean.success("删除成功").setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); }catch(ImppBusiException busExcep){ - LOGGER.error(busExcep.getErrorMsg() + "：{}",busExcep.getErrorDetail(),busExcep); return ResultBean.fail(busExcep); }catch(Exception e){ - LOGGER.error(ImppExceptionEnum.SYSTEM_EXCEPTION.getDescription() + "：{}",e.getMessage(),e); - return ResultBean.fail().setCode(ImppExceptionEnum.SYSTEM_EXCEPTION.getCode()); + return ImppExceptionBuilder.newInstance().buildExceptionResult(e); } } } diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/mq/LetterQueueReceiver.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/mq/LetterQueueReceiver.java index da8aab6..60b7e57 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/mq/LetterQueueReceiver.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/mq/LetterQueueReceiver.java @@ -14,7 +14,6 @@ import org.apache.commons.lang3.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.amqp.core.Message; -import org.springframework.amqp.rabbit.annotation.RabbitListener; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Component; @@ -44,7 +43,7 @@ public class LetterQueueReceiver { * @param message * 发送：rabbitTemplate.convertAndSend(I3CoreQueueConfig.IMPP_MESSAGE_QUEUE, new SysMessage(....)); */ - @RabbitListener(queues = I3CoreQueueConfig.IMPP_MESSAGE_LETTER_QUEUE) + //@RabbitListener(queues = I3CoreQueueConfig.IMPP_MESSAGE_LETTER_QUEUE) public void processImppMessage(SysMessage msg, Channel channel, Message message) { try { LOGGER.info("【MQ-IMPP_MESSAGE_LETTER_QUEUE】数据接收成功：{}",msg); @@ -82,7 +81,7 @@ public class LetterQueueReceiver { ); } - msg.setMessageSenderNameRdd(StringUtils.join(receiverName, ",")); + msg.setMessageReceiversNameRdd(StringUtils.join(receiverName, ",")); sysMessageService.updateSysMessage(msg); diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysTaskTimeExpressionService.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysTaskTimeExpressionService.java index 02e610e..69b25df 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysTaskTimeExpressionService.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysTaskTimeExpressionService.java @@ -11,6 +11,7 @@ import cn.estsh.i3plus.pojo.platform.repository.SysTaskTimeRepository; import cn.estsh.i3plus.pojo.platform.sqlpack.CoreHqlPack; import cn.estsh.impp.framework.boot.exception.ImppExceptionBuilder; import cn.estsh.impp.framework.boot.exception.ImppExceptionEnum; +import io.swagger.annotations.ApiOperation; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; @@ -37,36 +38,42 @@ public class SysTaskTimeExpressionService implements ISysTaskTimeExpressionServi private SysTaskTimeRepository taskTimeRDao; @Override + @ApiOperation(value = "修改数据") public void updateSysTaskTimeExpression(SysTaskTimeExpression taskTimeExpression) { LOGGER.info("定时任务时间表达式 TASK_TIME_EXPRESSION :{}", taskTimeExpression); taskTimeExpressionRDao.update(taskTimeExpression); } @Override + @ApiOperation(value = "根据id删除数据") public void deleteSysTaskTimeExpressionById(Long id) { LOGGER.info("定时任务时间表达式 TASK_TIME_EXPRESSION :{}", id); taskTimeExpressionRDao.deleteById(id); } @Override + @ApiOperation(value = "新增数据") public SysTaskTimeExpression insertSysTaskTimeExpression(SysTaskTimeExpression taskTimeExpression) { LOGGER.info("定时任务时间表达式 TASK_TIME_EXPRESSION :{}", taskTimeExpression); return taskTimeExpressionRDao.insert(taskTimeExpression); } @Override + @ApiOperation(value = "查询所有数据") public List listSysTaskTimeExpression() { LOGGER.info("定时任务时间表达式 TASK_TIME_EXPRESSION list"); return taskTimeExpressionRDao.list(); } @Override + @ApiOperation(value = "根据ID 查询任务表达式") public SysTaskTimeExpression getSysTaskTimeExpressionById(Long id) { LOGGER.info("定时任务时间表达式 TASK_TIME_EXPRESSION :{}" ,id); return taskTimeExpressionRDao.getById(id); } @Override + @ApiOperation(value = "任务表达式查询，分页，排序") public ListPager querySysTaskTimeExpressionByPager(SysTaskTimeExpression taskTimeExpression, Pager pager) { LOGGER.info("文件表达式 TASK_TIME_EXPRESSION taskTimeExpression:{}，Pager:{}",taskTimeExpression,pager); if(taskTimeExpression == null) { @@ -80,9 +87,10 @@ public class SysTaskTimeExpressionService implements ISysTaskTimeExpressionServi } @Override + @ApiOperation(value = "任务表达式批量删除") public void deleteSysTaskTimeExpressionByIds(Long[] ids) { LOGGER.info("文件表达式 SYS_MENU ids:{}", ids); - long count = taskTimeRDao.findByHqlWhereCount(CoreHqlPack.packHqlIds("timeId",ids)); + long count = taskTimeRDao.findByHqlWhereCount(CoreHqlPack.packHqlIds("timeExpressionId",ids)); if(count >= 1){ throw ImppExceptionBuilder.newInstance() .setSystemID(CommonEnumUtil.SOFT_TYPE.CORE.getCode()) diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysTaskTimeService.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysTaskTimeService.java index ce61014..81e3580 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysTaskTimeService.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysTaskTimeService.java @@ -16,6 +16,7 @@ import cn.estsh.i3plus.pojo.platform.sqlpack.CoreHqlPack; import cn.estsh.impp.framework.boot.exception.ImppExceptionBuilder; import cn.estsh.impp.framework.boot.exception.ImppExceptionEnum; import cn.estsh.impp.framework.boot.util.ValidatorBean; +import io.swagger.annotations.ApiOperation; import org.apache.commons.lang3.StringUtils; import org.quartz.*; import org.slf4j.Logger; @@ -36,7 +37,7 @@ import java.util.List; * @Modify : **/ @Service -public class SysTaskTimeService implements ISysTaskTimeService { +public class SysTaskTimeService implements ISysTaskTimeService{ public static final Logger LOGGER = LoggerFactory.getLogger(SysTaskTimeService.class); @@ -50,16 +51,16 @@ public class SysTaskTimeService implements ISysTaskTimeService { private Scheduler scheduler; @Override + @ApiOperation(value = "修改定时任务") public void updateSysTaskTime(SysTaskTime taskTime, SysTaskTimeExpression taskTimeExpression) { SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); SysTaskTime oldSysTaskTime = taskTimeRDao.getById(taskTime.getId()); // 更新关系表 - refExpressionTriggerRDao.updateByProperties( - "expressionId",oldSysTaskTime.getTimeExpressionId(), - new String[]{"name","groupName"}, - new String[]{oldSysTaskTime.getName(),taskTime.getGroupName()} + refExpressionTriggerRDao.updateByProperties(new String[]{"triggerName","triggerGroupName"}, + new String[]{oldSysTaskTime.getName(),taskTime.getGroupName()}, + "expressionId",oldSysTaskTime.getTimeExpressionId() ); taskTimeRDao.update(taskTime); @@ -106,6 +107,7 @@ public class SysTaskTimeService implements ISysTaskTimeService { } @Override + @ApiOperation(value = "修改任务状态") public void updateSysTaskTimeStatus(Long id, int status, SessionUser user) { LOGGER.info("定时任务 SYS_MENU id:{} status:{} user:{}", id,status,user); SysTaskTime taskTime = taskTimeRDao.getById(id); @@ -130,6 +132,7 @@ public class SysTaskTimeService implements ISysTaskTimeService { } @Override + @ApiOperation(value = "根据根据id删除数据") public void deleteSysTaskTimeById(Long id) { try { SysTaskTime taskTime = taskTimeRDao.getById(id); @@ -160,6 +163,7 @@ public class SysTaskTimeService implements ISysTaskTimeService { } @Override + @ApiOperation(value = "新增定时任务") public SysTaskTime insertSysTaskTime(SysTaskTime taskTime, SysTaskTimeExpression taskTimeExpression) { try { SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); @@ -226,18 +230,21 @@ public class SysTaskTimeService implements ISysTaskTimeService { } @Override + @ApiOperation(value = "查询所有数据") public List listSysTaskTime() { LOGGER.info("定时任务 TASK_TIME find All"); return taskTimeRDao.findAll(); } @Override + @ApiOperation(value = "根据id 数据") public SysTaskTime getSysTaskTimeById(Long id) { LOGGER.info("定时任务 TASK_TIME find id:{}", id); return taskTimeRDao.getOne(id); } @Override + @ApiOperation(value = "定时任务复制查询，分页，排序") public ListPager querySysTaskTimeByPager(SysTaskTime taskTime, Pager pager) { LOGGER.info("定时任务 TASK_TIME SysTaskTime:{}，Pager:{}",taskTime,pager); if(taskTime == null) { @@ -251,12 +258,14 @@ public class SysTaskTimeService implements ISysTaskTimeService { } @Override + @ApiOperation(value = "根据id批量删除定时任务") public void deleteSysTaskTimeByIds(Long[] ids) { LOGGER.info("定时任务 TASK_TIME ids:{}", ids.toString()); taskTimeRDao.deleteByIds(ids); } @Override + @ApiOperation(value = "批量修改定时任务状态") public void updateSysTaskTimeStatusByIds(Long[] ids, Integer status) { LOGGER.info("定时任务 TASK_TIME ids：{}，status：{}",ids,status); StringBuffer where = new StringBuffer(); @@ -266,6 +275,7 @@ public class SysTaskTimeService implements ISysTaskTimeService { } @Override + @ApiOperation(value = "修改最后时间") public void doSysTaskTimeLastDateByNameAndGroupName(String lastDate, String name, String groupName) { taskTimeRDao.updateByProperties( new String[]{"name","groupName"},new String[]{name,groupName}, @@ -273,6 +283,7 @@ public class SysTaskTimeService implements ISysTaskTimeService { } @Override + @ApiOperation(value = "立即执行") public void executeSysTaskTimeById(Long id) { SysTaskTime taskTime = taskTimeRDao.getById(id); JobKey jobKey = JobKey.jobKey(taskTime.getName(),taskTime.getGroupName()); From 5b154b40df6fde3ae7bc88de709dd3e51283a0ec Mon Sep 17 00:00:00 2001 From: "yunhao.wang" Date: Thu, 29 Nov 2018 21:59:23 +0800 Subject: [PATCH 2/2] =?UTF-8?q?=E5=AD=97=E5=85=B8=E7=AE=A1=E7=90=86?= =?UTF-8?q?=E4=BC=98=E5=8C=96?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../api/iservice/busi/ISysDictionaryService.java | 14 ++++++++++++- .../serviceimpl/busi/SysDictionaryService.java | 23 ++++++++++++++++++---- 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysDictionaryService.java b/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysDictionaryService.java index 6cdbe5e..c2169df 100644 --- a/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysDictionaryService.java +++ b/modules/i3plus-core-api/src/main/java/cn/estsh/i3plus/core/api/iservice/busi/ISysDictionaryService.java @@ -3,6 +3,7 @@ package cn.estsh.i3plus.core.api.iservice.busi; import cn.estsh.i3plus.pojo.base.bean.ListPager; import cn.estsh.i3plus.pojo.base.common.Pager; import cn.estsh.i3plus.pojo.platform.bean.SysDictionary; +import io.swagger.annotations.ApiOperation; import java.util.List; @@ -19,24 +20,28 @@ public interface ISysDictionaryService { * 添加字典 * @param sysDictionary */ + @ApiOperation(value = "添加字典") void insertSysDictionary(SysDictionary sysDictionary); /** * 根据id删除字典 * @param id */ + @ApiOperation(value = "根据id删除字典") void deleteSysDictionaryById(Long id); /** * 修改字典 * @param sysDictionary */ + @ApiOperation(value = "修改字典") void updateSysDictionary(SysDictionary sysDictionary); /** * 查询所有字典信息 * @return */ + @ApiOperation(value = "查询所有字典信息") List listSysDictionary(); /** @@ -44,6 +49,7 @@ public interface ISysDictionaryService { * @param id * @return */ + @ApiOperation(value = "根据id查询字典信息") SysDictionary getSysDictionaryById(Long id); /** @@ -51,23 +57,27 @@ public interface ISysDictionaryService { * @param parentCode * @return */ + @ApiOperation(value = "根据父级代码查询字典项信息") List findSysDictionaryByParentCode(String parentCode); /** * 字典复杂查询，分页，排序 * 默认查询非顶级字典 */ + @ApiOperation(value = "字典复杂查询，分页，排序",notes = "默认查询非顶级字典") ListPager querySysDictionaryByPager(SysDictionary sysDictionary, Pager pager); /** * 查询顶级字典 */ + @ApiOperation(value = "查询顶级字典") List findSysDictionaryByTop(); /** * 批量删除字典 * @param ids */ + @ApiOperation(value = "批量删除字典") void deleteSysDictionaryByIds(Long[] ids); /** @@ -75,13 +85,15 @@ public interface ISysDictionaryService { * @param fileName * @return */ + @ApiOperation(value = "检出文件名称是否符合系统规范") boolean checkFileName(String fileName); /** - * 根据父节点 已经当前节点CODE 获取字典信息 + * 根据父节点 以及当前节点CODE 获取字典信息 * @param parentCode * @param code * @return */ + @ApiOperation(value = "根据父节点 以及当前节点CODE 获取字典信息") SysDictionary getSysDictionaryByParentCodeAndCode(String parentCode,String code); } diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysDictionaryService.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysDictionaryService.java index dc9f430..aa8469b 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysDictionaryService.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysDictionaryService.java @@ -14,6 +14,7 @@ import cn.estsh.i3plus.pojo.platform.sqlpack.CoreHqlPack; import cn.estsh.impp.framework.boot.exception.ImppExceptionBuilder; import cn.estsh.impp.framework.boot.exception.ImppExceptionEnum; import cn.estsh.impp.framework.boot.util.ValidatorBean; +import io.swagger.annotations.ApiOperation; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; @@ -36,9 +37,11 @@ public class SysDictionaryService implements ISysDictionaryService { private SysDictionaryRepository sysDictionaryRDao; @Override + @ApiOperation(value = "添加字典") public void insertSysDictionary(SysDictionary sysDictionary) { - long repeatCount = sysDictionaryRDao.findByPropertyCount("dictionaryCode",sysDictionary.getDictionaryCode()); - if (repeatCount > 0){ + long repeatCodeCount = sysDictionaryRDao.findByPropertyCount("dictionaryCode",sysDictionary.getDictionaryCode()); + long repeatValueCount = sysDictionaryRDao.findByPropertyCount("dictionaryValue",sysDictionary.getDictionaryValue()); + if (repeatCodeCount > 0 || repeatValueCount > 0){ throw ImppExceptionBuilder.newInstance() .setSystemID(CommonEnumUtil.SOFT_TYPE.CORE.getCode()) .setErrorCode(ImppExceptionEnum.IO_EXCEPTION.getCode()) @@ -64,17 +67,21 @@ public class SysDictionaryService implements ISysDictionaryService { } @Override + @ApiOperation(value = "根据id删除字典") public void deleteSysDictionaryById(Long id) { LOGGER.info("字典 SYS_DICTIONARY id:{}",id); sysDictionaryRDao.deleteById(id); } @Override + @ApiOperation(value = "修改字典") public void updateSysDictionary(SysDictionary sysDictionary) { // 校验唯一 String hqlPack = CoreHqlPack.packHqlSysDictionaryCode(sysDictionary); - long repeatCount = sysDictionaryRDao.findByHqlWhereCount(hqlPack); - if (repeatCount > 0){ + long repeatCodeCount = sysDictionaryRDao.findByHqlWhereCount(hqlPack); + hqlPack = CoreHqlPack.packHqlSysDictionaryValue(sysDictionary); + long repeatValueCount = sysDictionaryRDao.findByHqlWhereCount(hqlPack); + if (repeatCodeCount > 0 || repeatValueCount > 0){ throw ImppExceptionBuilder.newInstance() .setSystemID(CommonEnumUtil.SOFT_TYPE.CORE.getCode()) .setErrorCode(ImppExceptionEnum.VARIFY_EXCEPTION_DATA_EXIT.getCode()) @@ -98,24 +105,28 @@ public class SysDictionaryService implements ISysDictionaryService { } @Override + @ApiOperation(value = "查询所有字典信息") public List listSysDictionary() { LOGGER.info("字典 SYS_DICTIONARY list"); return sysDictionaryRDao.list(); } @Override + @ApiOperation(value = "根据id查询字典信息") public SysDictionary getSysDictionaryById(Long id) { LOGGER.info("字典 SYS_DICTIONARY id:{}",id); return sysDictionaryRDao.getById(id); } @Override + @ApiOperation(value = "根据父级代码查询字典项信息") public List findSysDictionaryByParentCode(String parentCode) { LOGGER.info("字典 SYS_DICTIONARY parentCode:{}",parentCode); return sysDictionaryRDao.findByProperty("parentCodeRdd",parentCode); } @Override + @ApiOperation(value = "字典复杂查询，分页，排序",notes = "默认查询非顶级字典") public ListPager querySysDictionaryByPager(SysDictionary sysDictionary, Pager pager) { sysDictionary = sysDictionary == null ? new SysDictionary():sysDictionary; @@ -125,18 +136,21 @@ public class SysDictionaryService implements ISysDictionaryService { } @Override + @ApiOperation(value = "查询顶级字典") public List findSysDictionaryByTop() { LOGGER.info("字典 SYS_DICTIONARY parentId:{}", CommonEnumUtil.PARENT.DEFAULT.getValue()); return sysDictionaryRDao.findByProperty("parentId",(long)CommonEnumUtil.PARENT.DEFAULT.getValue()); } @Override + @ApiOperation(value = "批量删除字典") public void deleteSysDictionaryByIds(Long[] ids) { LOGGER.info("字典 SYS_DICTIONARY ids:{}", ids.toString()); sysDictionaryRDao.deleteByIds(ids); } @Override + @ApiOperation(value = "检出文件名称是否符合系统规范") public boolean checkFileName(String fileName) { List list = findSysDictionaryByParentCode(CommonConstWords.DICTIONARY_FILE_TYPE); @@ -153,6 +167,7 @@ public class SysDictionaryService implements ISysDictionaryService { } @Override + @ApiOperation(value = "根据父节点 以及当前节点CODE 获取字典信息") public SysDictionary getSysDictionaryByParentCodeAndCode(String parentCode, String code) { List list = sysDictionaryRDao.findByProperty(new String[]{"parentCodeRdd","dictionaryCode"}, new Object[]{parentCode,code});