From ace95247335eae405f8c28b7ae48c53512ea9e58 Mon Sep 17 00:00:00 2001 From: "wei.peng" Date: Thu, 21 Mar 2019 19:31:30 +0800 Subject: [PATCH] =?UTF-8?q?FindBugs=20=E6=8F=90=E7=A4=BABug=20=E4=BF=AE?= =?UTF-8?q?=E6=94=B9?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../estsh/i3plus/core/apiservice/controller/DemoCloudController.java | 2 +- .../i3plus/core/apiservice/controller/busi/SysUserInfoController.java | 3 +-- .../i3plus/core/apiservice/serviceimpl/busi/SysDictionaryService.java | 2 +- .../i3plus/core/apiservice/serviceimpl/busi/SysFileServiceImpl.java | 2 +- .../i3plus/core/apiservice/serviceimpl/busi/SysMessageService.java | 2 +- .../i3plus/core/apiservice/serviceimpl/busi/SysToolTypeService.java | 2 +- 6 files changed, 6 insertions(+), 7 deletions(-) diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoCloudController.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoCloudController.java index 407c96a..e18d1c8 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoCloudController.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/DemoCloudController.java @@ -120,7 +120,7 @@ public class DemoCloudController { @ApiOperation(value="测试arr",notes = "测试arr") public ResultBean testFeignArr(@RequestBody String[] arr) { LOGGER.info("【impp-core-arr接受数据】{}" ,arr); - return ResultBean.success("返回：" + arr).setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); + return ResultBean.success("返回成功").setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()).setResultObject(arr); } @PostMapping(value="/test-more-object") diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysUserInfoController.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysUserInfoController.java index e0b400a..ebea10a 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysUserInfoController.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/controller/busi/SysUserInfoController.java @@ -164,8 +164,7 @@ public class SysUserInfoController extends CoreBaseController{ ValidatorBean.checkIsNumber(id, "id 不能为空"); SysUserInfo userInfo = sysUserInfoService.getSysUserInfoById(Long.parseLong(id)); - ValidatorBean.beginValid(userInfo) - .notNull("id",userInfo.getId()); + ValidatorBean.beginValid(userInfo).notNull("id",userInfo.getId()); if(userInfo != null){ return ResultBean.success("操作成功").setResultObject(userInfo).setCode(ResourceEnumUtil.MESSAGE.SUCCESS.getCode()); diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysDictionaryService.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysDictionaryService.java index 83a6f9f..11877b1 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysDictionaryService.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysDictionaryService.java @@ -168,7 +168,7 @@ public class SysDictionaryService implements ISysDictionaryService { .build(); } - LOGGER.info("字典 SYS_DICTIONARY ids:{}", ids.toString()); + LOGGER.info("字典 SYS_DICTIONARY ids:{}", ids); sysDictionaryRDao.deleteByIds(ids); } diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysFileServiceImpl.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysFileServiceImpl.java index 2679be5..95cbdac 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysFileServiceImpl.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysFileServiceImpl.java @@ -96,7 +96,7 @@ public class SysFileServiceImpl implements ISysFileService { @Override public void deleteSysFileByIds(Long[] ids) { - LOGGER.info("文件资源 SYS_FILE ids:{}", ids.toString()); + LOGGER.info("文件资源 SYS_FILE ids:{}", ids); sysFileRDao.deleteByIds(ids); } diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysMessageService.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysMessageService.java index 398613b..37a1452 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysMessageService.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysMessageService.java @@ -116,7 +116,7 @@ public class SysMessageService implements ISysMessageService { @Override @ApiOperation(value = "批量删除消息") public void deleteSysMessageByIds(Long[] ids) { - LOGGER.info("消息 SYS_MESSAGE ids:{}", ids.toString()); + LOGGER.info("消息 SYS_MESSAGE ids:{}", ids); sysMessageRDao.deleteByIds(ids); } diff --git a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysToolTypeService.java b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysToolTypeService.java index 11548e1..b8fa9b9 100644 --- a/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysToolTypeService.java +++ b/modules/i3plus-core-apiservice/src/main/java/cn/estsh/i3plus/core/apiservice/serviceimpl/busi/SysToolTypeService.java @@ -102,7 +102,7 @@ public class SysToolTypeService implements ISysToolTypeService { @Override @ApiOperation(value = "删除硬件类型",notes = "根据 ID 批量删除硬件类型信息") public void deleteSysToolTypeByIds(Long[] ids) { - LOGGER.info("硬件类型 TOOL_TYPE ids:{}", ids.toString()); + LOGGER.info("硬件类型 TOOL_TYPE ids:{}", ids); List count = toolRDao.findByHqlWhere(CoreHqlPack.packHqlIds("toolTypeId",ids)); if(count.size() > 0){ throw ImppExceptionBuilder.newInstance()